Skip to content

feat(smartlog): switch from ◯ to ○ for visible commit nodes #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(smartlog): switch from ◯ to ○ for visible commit nodes #1271

wants to merge 1 commit into from
+1 −1

Conversation

xuanduc987
Copy link

U+25EF is unicode LARGE CIRCLE thus would be rendered visibly larger than other node. I believe U+25CB WHITE CIRCLE should be used instead.

Bellow is the list of icons used to denote commit node

node symbol
commit_visible(before) ◯
commit_visible(this PR) ○
commit_visible_head ●
commit_obsolete ✕
commit_obsolete_head ⦻
commit_omitted ◌
commit_merge ↓
commit_main ◇
commit_main_head ◆
commit_main_obsolete ✕
commit_main_obsolete_head ❖

@adzenith
Copy link
Contributor

This PR takes the opposite approach and makes the filled-in circle larger

@xuanduc987
feat(smartlog): switch from ◯ to ○ for visible commit nodes
d61124a 
U+25EF is unicode LARGE CIRCLE thus would be rendered visibly larger than other node.
I believe U+25CB WHITE CIRCLE should be used instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuanduc987 @adzenith